Create Vacated Decision Issues from Request Issues #13173

jcq · 2020-01-16T00:33:35Z

Connects #13069

Description

This adds code to create vacated decision issues from given request issues

…ision issues

adjusted tests accordingly;

…active atty to pass (ensure variables are created in necessary order)

…nUpdater rather than on frontend; additional fields saved in newly created request issues;

…issue_ids for full grant

…field

…ecisionMotionUpdater

…nIssue

codeclimate · 2020-01-16T00:38:00Z

Code Climate has analyzed commit 0d24049 and detected 0 issues on this pull request.

View more on Code Climate.

…cisionMotion; moved `create_vacated_decision_issue` in RequestIssue to make method accessible;

leikkisa

I added some thoughts and proposals below. Let me know if you have any questions.

app/models/post_decision_motion.rb

app/models/request_issue.rb

spec/models/post_decision_motion_spec.rb

db/schema.rb

…otion: renamed methods, and separated methods for creation of issues from those that return said issues; renamed tests;

this creates request issues & decision issues based off the specified PostDecisionMotion

leikkisa

I'm prematurely adding a few comments for when this is adapted to the new appeal stream flow, after #13325

leikkisa · 2020-02-04T17:56:31Z

app/models/decision_issue.rb

@@ -160,7 +160,7 @@ def associated_request_issue
  end

  def create_contesting_request_issue!
-    RequestIssue.create!(
+    RequestIssue.find_or_create_by!(
      decision_review: decision_review,


These are now going to be added onto the new appeal stream instead of the original appeal

app/models/request_issue.rb

leikkisa · 2020-02-04T17:57:49Z

app/controllers/post_decision_motions_controller.rb

@@ -25,6 +25,17 @@ def return_to_lit_support
    render json: { tasks: ::WorkQueue::TaskSerializer.new(appeal_tasks, is_collection: true) }
  end

+  def create_issues


I think it makes sense to move creating issues to the PostDecisionMotionUpdater, when the new appeal stream is getting created

Yeah, if their creation is automatic we don't need an endpoint for it.

Methinks it makes sense to wait until your PR (#13325) lands and then incorporate upon new stream creation.

…sues to new "vacate" appeal stream

…tionUpdater; new issues are created on the vacate stream;

leikkisa

Hey JC - it looks like there's some "clean up" from the previous iteration of the code left, but besides that, this PR is looking good, so I'll go ahead and give it the approval now.

leikkisa · 2020-02-07T18:13:46Z

app/models/decision_issue.rb

@@ -160,8 +160,9 @@ def associated_request_issue
  end

  def create_contesting_request_issue!
-    RequestIssue.create!(
-      decision_review: decision_review,
+    vacate_appeal_stream = Appeal.find_by(stream_type: "vacate", stream_docket_number: decision_review.docket_number)


This is good for now, we'll probably update it in Sandra's ticket to pass in the decision review so it can be used for De Novo's too.

config/routes.rb

spec/controllers/post_decision_motions_controller_spec.rb

leikkisa · 2020-02-07T18:45:38Z

spec/workflows/post_decision_motion_updater_spec.rb

@@ -65,6 +65,8 @@
          expect(task.reload.status).to eq Constants.TASK_STATUSES.completed
          verify_vacate_stream
        end
+
+        it "should create decision issues on new vacate"


This looks like a stray line

leikkisa · 2020-02-07T18:46:17Z

spec/workflows/post_decision_motion_updater_spec.rb

+    expect(request_issues.size).to eq(motion.decision_issues_for_vacatur.size)
+
+    decision_issues = vacate_stream.decision_issues
+    expect(decision_issues.size).to eq(motion.decision_issues_for_vacatur.size)


…oller

JC Quirin and others added 21 commits December 18, 2019 12:41

added basic support for creating request issues from selected MTV dec…

38b1d58

…ision issues

only create request issues if disposition is grant type

8d5c8f3

Merge branch 'master' into jc/12373-mtv-create-request-issues

83d41bc

moved creation of request issues to PostDecisionMotion model;

1f4cea5

adjusted tests accordingly;

Merge branch 'master' into jc/12373-mtv-create-request-issues

a9470c4

adjustments to post_decision_motion_updater_spec to allow tests re in…

29af3f7

…active atty to pass (ensure variables are created in necessary order)

linting

63ba17f

we now save all MTV issue IDs for "granted" disposition

c3a5296

Merge branch 'master' into jc/12373-mtv-create-request-issues

c4488d2

we now add all decision issue IDs for full grant in PostDecisionMotio…

80cf6b8

…nUpdater rather than on frontend; additional fields saved in newly created request issues;

added test for PostDecisionMotionUpdater adding all vacated_decision_…

b55570f

…issue_ids for full grant

linting

84e4cac

updated schema to indicate addtl usage of vacated_decision_issue_ids …

18451dc

…field

better logic for populating vacated_decision_issue_ids field in PostD…

84140b9

…ecisionMotionUpdater

fixed wrong naming in disposition check in PostDecisionMotionUpdater

4707bfc

Merge branch 'master' into jc/12373-mtv-create-request-issues

9d6fce1

removed superfluous commented line

504fc81

moved logic for creating request issue from decision issue to Decisio…

c0b14b8

…nIssue

began adding new_decision_issue_from! method to RequestIssue

ae016df

Merge branch 'master' into jc/13069-mtv-create-decision-issues

99fcccb

updated method name in RequestIssue to "create_vacated_decision_issue!"

dc869f3

JC Quirin added 2 commits January 15, 2020 17:30

added code & tests for generating vacated decision issues from PostDe…

9c4536f

…cisionMotion; moved `create_vacated_decision_issue` in RequestIssue to make method accessible;

adjustments per codeclimate

425cdf9

leikkisa reviewed Jan 17, 2020

View reviewed changes

JC Quirin added 5 commits January 17, 2020 16:19

Merge branch 'master' into jc/13069-mtv-create-decision-issues

b98d0c5

Merge branch 'master' into jc/13069-mtv-create-decision-issues

fb34f9d

updated various items in DecisionIssue, RequestIssue, & PostDecisionM…

f684246

…otion: renamed methods, and separated methods for creation of issues from those that return said issues; renamed tests;

Merge branch 'master' into jc/13069-mtv-create-decision-issues

a26e0c9

fixed error in MTV test

ea02577

JC Quirin and others added 5 commits January 21, 2020 11:41

Merge branch 'master' into jc/13069-mtv-create-decision-issues

74679be

began adding PostDecisionMotionController.create_issues endpoint & tests

7d01a8b

added "create_issues" endpoint on PostDecisionMotionsController:

1e2baaa

this creates request issues & decision issues based off the specified PostDecisionMotion

linting

8e78862

removed mistaken commit of modified capybara.rb

cb160e0

leikkisa mentioned this pull request Jan 23, 2020

Motion to Vacate | Granted | After AddressMotionToVacate, create appeal stream if granted #13222

Closed

5 tasks

leikkisa reviewed Feb 4, 2020

View reviewed changes

DecisionIssue.create_contesting_request_issue now adds new request is…

be25dff

…sues to new "vacate" appeal stream

leikkisa added the Team: Foxtrot 🦊 label Feb 7, 2020

JC Quirin added 3 commits February 7, 2020 09:10

Merge branch 'master' into jc/13069-mtv-create-decision-issues

ae0395c

moved calls to create new request & decision issues to PostDecisionMo…

b9ee9a6

…tionUpdater; new issues are created on the vacate stream;

removed create_issues & related from PostDecisionMotionsController

c376303

leikkisa approved these changes Feb 7, 2020

View reviewed changes

JC Quirin added 3 commits February 7, 2020 12:50

updated tests in post_decision_motion_spec

ba135f4

removed tests for PostDecisionMotionsController.create_tasks

5d84d90

removed unsed route for create_issues off of PostDecisionMotionsContr…

583d3de

…oller

jcq added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Feb 7, 2020

Merge branch 'master' into jc/13069-mtv-create-decision-issues

0d24049

va-bot merged commit 01c19f7 into master Feb 7, 2020

va-bot deleted the jc/13069-mtv-create-decision-issues branch February 7, 2020 22:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Vacated Decision Issues from Request Issues #13173

Create Vacated Decision Issues from Request Issues #13173

jcq commented Jan 16, 2020 •

edited

Loading

codeclimate bot commented Jan 16, 2020 •

edited

Loading

leikkisa left a comment

leikkisa left a comment

leikkisa Feb 4, 2020

leikkisa Feb 4, 2020

jcq Feb 4, 2020

leikkisa left a comment

leikkisa Feb 7, 2020

leikkisa Feb 7, 2020

leikkisa Feb 7, 2020

Create Vacated Decision Issues from Request Issues #13173

Create Vacated Decision Issues from Request Issues #13173

Conversation

jcq commented Jan 16, 2020 • edited Loading

Description

codeclimate bot commented Jan 16, 2020 • edited Loading

leikkisa left a comment

Choose a reason for hiding this comment

leikkisa left a comment

Choose a reason for hiding this comment

leikkisa Feb 4, 2020

Choose a reason for hiding this comment

leikkisa Feb 4, 2020

Choose a reason for hiding this comment

jcq Feb 4, 2020

Choose a reason for hiding this comment

leikkisa left a comment

Choose a reason for hiding this comment

leikkisa Feb 7, 2020

Choose a reason for hiding this comment

leikkisa Feb 7, 2020

Choose a reason for hiding this comment

leikkisa Feb 7, 2020

Choose a reason for hiding this comment

jcq commented Jan 16, 2020 •

edited

Loading

codeclimate bot commented Jan 16, 2020 •

edited

Loading